Skip to content

fix(specs): insights-api timestamp documentation#5925

Merged
Fluf22 merged 3 commits intomainfrom
EEX-1799-Fix-timestamp-documentation-in-spec
Feb 6, 2026
Merged

fix(specs): insights-api timestamp documentation#5925
Fluf22 merged 3 commits intomainfrom
EEX-1799-Fix-timestamp-documentation-in-spec

Conversation

@sirockin
Copy link
Copy Markdown
Contributor

@sirockin sirockin commented Feb 3, 2026

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/EEX-1799

Changes included:

  • Add 30 day limit to description
  • Correct example error message

@sirockin sirockin requested a review from a team as a code owner February 3, 2026 06:33
@algolia-bot
Copy link
Copy Markdown
Collaborator

algolia-bot commented Feb 3, 2026

✔️ Code generated!

Name Link
🪓 Triggered by 922939def8a834eadb9bc9564648f133e6475df5
🍃 Generated commit 43054f5ff0ec2348df8902fc96a9cccac4202361
🌲 Generated branch generated/EEX-1799-Fix-timestamp-documentation-in-spec
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 2691
javascript 2433
php 1902
csharp 1644
python 1325
java 1151
ruby 911
swift 860
scala 23

Comment on lines +48 to +49
Timestamp of the event, measured in milliseconds since the Unix epoch. Must be no older than 30 days.
If not provided, we use the time at which the request was received.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw this commit by chance. Just wanted to share out my two cents as someone who spends a lot of time in documentation:

Suggested change
Timestamp of the event, measured in milliseconds since the Unix epoch. Must be no older than 30 days.
If not provided, we use the time at which the request was received.
Timestamp of the event, measured in milliseconds since the Unix epoch.
The timestamp must not be more than 30 days in the past relative to the time the request is received. If omitted, the timestamp defaults to the time when the request is received.
  • 30 days compared to what? Explicit > Implicit
  • we use the time. Who is we? It's probably a computer program.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirockin I'd like to integrate Kai's recommendations
Are you okay with them?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes no problem

@Fluf22 Fluf22 enabled auto-merge (squash) February 6, 2026 15:50
@Fluf22 Fluf22 merged commit 799a10c into main Feb 6, 2026
36 checks passed
@Fluf22 Fluf22 deleted the EEX-1799-Fix-timestamp-documentation-in-spec branch February 6, 2026 16:02
algolia-bot added a commit that referenced this pull request Feb 6, 2026
…[skip ci]

Co-authored-by: Dave Sirockin <dave@sirockin.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Feb 6, 2026
algolia/api-clients-automation#5925

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Dave Sirockin <dave@sirockin.com>
algolia-bot added a commit to algolia/algoliasearch-client-dart that referenced this pull request Feb 6, 2026
algolia/api-clients-automation#5925

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Dave Sirockin <dave@sirockin.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Feb 6, 2026
algolia/api-clients-automation#5925

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Dave Sirockin <dave@sirockin.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Feb 6, 2026
algolia/api-clients-automation#5925

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Dave Sirockin <dave@sirockin.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Feb 6, 2026
algolia/api-clients-automation#5925

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Dave Sirockin <dave@sirockin.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Feb 6, 2026
algolia/api-clients-automation#5925

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Dave Sirockin <dave@sirockin.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Feb 6, 2026
algolia/api-clients-automation#5925

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Dave Sirockin <dave@sirockin.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Feb 6, 2026
algolia/api-clients-automation#5925

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Dave Sirockin <dave@sirockin.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Feb 6, 2026
algolia/api-clients-automation#5925

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Dave Sirockin <dave@sirockin.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Feb 6, 2026
algolia/api-clients-automation#5925

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Dave Sirockin <dave@sirockin.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Feb 6, 2026
algolia/api-clients-automation#5925

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Dave Sirockin <dave@sirockin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants