fix(specs): more accurate composition behavior typing#5892
Merged
gavinwade12 merged 1 commit intomainfrom Jan 29, 2026
Merged
Conversation
Collaborator
💥 Breaking changes detected !!Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging. ✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
1342e22 to
d5ca66f
Compare
ClaraMuller
approved these changes
Jan 28, 2026
d5ca66f to
a6f8a8f
Compare
algolia-bot
added a commit
that referenced
this pull request
Jan 29, 2026
…ted) [skip ci] Co-authored-by: Gavin Wade <gavin.wade12@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-csharp
that referenced
this pull request
Jan 29, 2026
algolia/api-clients-automation#5892 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Gavin Wade <gavin.wade12@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-dart
that referenced
this pull request
Jan 29, 2026
algolia/api-clients-automation#5892 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Gavin Wade <gavin.wade12@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-go
that referenced
this pull request
Jan 29, 2026
algolia/api-clients-automation#5892 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Gavin Wade <gavin.wade12@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-java
that referenced
this pull request
Jan 29, 2026
algolia/api-clients-automation#5892 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Gavin Wade <gavin.wade12@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Jan 29, 2026
algolia/api-clients-automation#5892 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Gavin Wade <gavin.wade12@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-kotlin
that referenced
this pull request
Jan 29, 2026
algolia/api-clients-automation#5892 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Gavin Wade <gavin.wade12@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-php
that referenced
this pull request
Jan 29, 2026
algolia/api-clients-automation#5892 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Gavin Wade <gavin.wade12@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-python
that referenced
this pull request
Jan 29, 2026
algolia/api-clients-automation#5892 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Gavin Wade <gavin.wade12@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-ruby
that referenced
this pull request
Jan 29, 2026
algolia/api-clients-automation#5892 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Gavin Wade <gavin.wade12@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-scala
that referenced
this pull request
Jan 29, 2026
algolia/api-clients-automation#5892 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Gavin Wade <gavin.wade12@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-swift
that referenced
this pull request
Jan 29, 2026
algolia/api-clients-automation#5892 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Gavin Wade <gavin.wade12@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
This PR changes the typing for composition behaviors to make it clear that either
injectionormultifeedmay be specified, but not both.Slack thread: https://algolia.slack.com/archives/C06TE5GB5R6/p1769606821341719?thread_ts=1768297965.225399&cid=C06TE5GB5R6
🎟 JIRA Ticket: CMP-683
Changes included:
compositionBehaviortype into aoneOfwith specified sub-types with required properties🧪 Test
yarn cli generate javascript compositionyields something equivalent totype CompositionBehavior = {injection: Injection} | {multifeed: Multifeed};instead oftype CompositionBehavior = {injection?: Injection; multifeed?: Multifeed};