Skip to content

fix(specs): allow additionalProperties on insights-api events#5885

Merged
Fluf22 merged 6 commits intomainfrom
EEX-1789-insights-api-data-field-forbidden-by-openapi-spec-but-supported-in-code
Jan 27, 2026
Merged

fix(specs): allow additionalProperties on insights-api events#5885
Fluf22 merged 6 commits intomainfrom
EEX-1789-insights-api-data-field-forbidden-by-openapi-spec-but-supported-in-code

Conversation

@sirockin
Copy link
Copy Markdown
Contributor

@sirockin sirockin commented Jan 27, 2026

🧭 What

Remove additionalProperties: false from insights-api events schemas.

🧭 Why

  • Our api already allows additional properties and we need to continue to support that
  • There is no reason to exclude additional properties - we already impose a limit on body size
  • Docs and implementation should be consistent
  • This is a non-breaking change

happy path failing on 20 as expected
insights-api implementation already allows aditional properties - this brings the documentation in line with the implementation
@sirockin sirockin requested a review from a team as a code owner January 27, 2026 11:16
@sirockin sirockin requested review from Fluf22 and shortcuts January 27, 2026 11:16
@algolia-bot
Copy link
Copy Markdown
Collaborator

algolia-bot commented Jan 27, 2026

💥 Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@21' CI job.

✔️ Code generated!

Name Link
🪓 Triggered by f921ebd3b8e38c1f933fd57af70355c629cc251e
🍃 Generated commit ac57d646567127ab60bf26f7cc15fed2b1d4e985
🌲 Generated branch generated/EEX-1789-insights-api-data-field-forbidden-by-openapi-spec-but-supported-in-code
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 2398
go 2227
php 1936
csharp 1504
python 1354
java 1166
ruby 982
swift 433
scala 23

@sirockin sirockin changed the title Fix: allow additionalProperties on insights-api events fix: allow additionalProperties on insights-api events Jan 27, 2026
@sirockin sirockin changed the title fix: allow additionalProperties on insights-api events fix(specs): allow additionalProperties on insights-api events Jan 27, 2026
Copy link
Copy Markdown
Collaborator

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change alert is for some older changes not yet released, so we can discard

Other than this whitespace, no issue on my side

Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
@Fluf22 Fluf22 enabled auto-merge (squash) January 27, 2026 15:11
@Fluf22 Fluf22 merged commit 52aed5b into main Jan 27, 2026
35 checks passed
@Fluf22 Fluf22 deleted the EEX-1789-insights-api-data-field-forbidden-by-openapi-spec-but-supported-in-code branch January 27, 2026 15:32
algolia-bot added a commit that referenced this pull request Jan 27, 2026
… (generated) [skip ci]

Co-authored-by: Dave Sirockin <dave@sirockin.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Jan 27, 2026
…ted)

algolia/api-clients-automation#5885

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Dave Sirockin <dave@sirockin.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Jan 27, 2026
…ted)

algolia/api-clients-automation#5885

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Dave Sirockin <dave@sirockin.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jan 27, 2026
…ted)

algolia/api-clients-automation#5885

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Dave Sirockin <dave@sirockin.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Jan 27, 2026
…ted)

algolia/api-clients-automation#5885

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Dave Sirockin <dave@sirockin.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Jan 27, 2026
…ted)

algolia/api-clients-automation#5885

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Dave Sirockin <dave@sirockin.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Jan 27, 2026
…ted)

algolia/api-clients-automation#5885

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Dave Sirockin <dave@sirockin.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Jan 27, 2026
…ted)

algolia/api-clients-automation#5885

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Dave Sirockin <dave@sirockin.com>
Co-authored-by: Thomas Raffray <Fluf22@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants