Skip to content

fix(specs): authentications type can't be updated#5824

Merged
Fluf22 merged 2 commits intomainfrom
docs/authentication-update
Jan 23, 2026
Merged

fix(specs): authentications type can't be updated#5824
Fluf22 merged 2 commits intomainfrom
docs/authentication-update

Conversation

@sbellone
Copy link
Copy Markdown
Contributor

@sbellone sbellone commented Jan 13, 2026

🧭 What and Why

When trying to send the curl command of the documentation, I get the following error:

{
  "error": {
    "code": "invalid_payload"
  },
  "message": "unknown field \"type\"",
  "status": 400
}

We indeed don't allow to update the authentication type:
https://github.com/algolia/data-ingestion/blob/a3b519077859b8456aac1149af9029ad80ed3d93/pkg/types/authenticationstypes/common.go#L51

Changes included:

  • Update the doc and the example
  • Unrelated: Also removed triggerType in the "List tasks" curl example as it's not something we expose anymore

@sbellone sbellone self-assigned this Jan 13, 2026
@sbellone sbellone requested a review from a team as a code owner January 13, 2026 16:43
@algolia-bot
Copy link
Copy Markdown
Collaborator

algolia-bot commented Jan 13, 2026 •
edited
Loading

💥 Breaking changes detected !!

Either this PR or a previous PR not released yet introduced breaking changes, be careful when merging.
You can find the details in the 'client java@21' CI job.

✔️ Code generated!

Name Link
🪓 Triggered by 3d210c485a5e8fc81ed01a737916a8d953a18e95
🍃 Generated commit 5260efcdf66a25a4cf135d726951a3848f3a6fee
🌲 Generated branch generated/docs/authentication-update
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 2409
go 2283
php 1958
csharp 1643
python 1416
java 1144
ruby 991
swift 520
scala 23

Fluf22
Fluf22 approved these changes Jan 23, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not forget to put a notice in the changelog about the breaking change, even if the API would never have accepted the payload
Some language will break because of this

@Fluf22 Fluf22 enabled auto-merge (squash) January 23, 2026 13:29
@sbellone sbellone changed the title docs: authentication type can't be updated fix!: authentications type can't be updated Jan 23, 2026
@sbellone
Copy link
Copy Markdown
Contributor Author

sbellone commented Jan 23, 2026 •
edited
Loading

Added in the commit name 👌
Edit: Oh, the title check can't parse those

@Fluf22
Copy link
Copy Markdown
Collaborator

Fluf22 commented Jan 23, 2026

Ah no! We need to put it in the changelog only, please 😁

@sbellone sbellone changed the title fix!: authentications type can't be updated fix: authentications type can't be updated Jan 23, 2026
@sbellone sbellone changed the title fix: authentications type can't be updated fix(specs): authentications type can't be updated Jan 23, 2026
@Fluf22 Fluf22 merged commit f9453e6 into main Jan 23, 2026
37 of 39 checks passed
@Fluf22 Fluf22 deleted the docs/authentication-update branch January 23, 2026 14:14
algolia-bot added a commit that referenced this pull request Jan 23, 2026
@algolia-bot @sbellone
docs: authentication type can't be updated (#5824) (generated) [skip ci]
061f711 
Co-authored-by: Sylvain Bellone <sylvain.bellone@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-csharp that referenced this pull request Jan 23, 2026
@algolia-bot @sbellone
docs: authentication type can't be updated (generated)
39b50a1 
algolia/api-clients-automation#5824

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Sylvain Bellone <sylvain.bellone@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-go that referenced this pull request Jan 23, 2026
@algolia-bot @sbellone
docs: authentication type can't be updated (generated)
7477281 
algolia/api-clients-automation#5824

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Sylvain Bellone <sylvain.bellone@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-java that referenced this pull request Jan 23, 2026
@algolia-bot @sbellone
docs: authentication type can't be updated (generated)
e1ce0dc 
algolia/api-clients-automation#5824

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Sylvain Bellone <sylvain.bellone@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jan 23, 2026
@algolia-bot @sbellone
docs: authentication type can't be updated (generated)
35d32dc 
algolia/api-clients-automation#5824

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Sylvain Bellone <sylvain.bellone@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-kotlin that referenced this pull request Jan 23, 2026
@algolia-bot @sbellone
docs: authentication type can't be updated (generated)
9e7a457 
algolia/api-clients-automation#5824

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Sylvain Bellone <sylvain.bellone@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Jan 23, 2026
@algolia-bot @sbellone
docs: authentication type can't be updated (generated)
8d890eb 
algolia/api-clients-automation#5824

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Sylvain Bellone <sylvain.bellone@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-python that referenced this pull request Jan 23, 2026
@algolia-bot @sbellone
docs: authentication type can't be updated (generated)
4d3e8bd 
algolia/api-clients-automation#5824

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Sylvain Bellone <sylvain.bellone@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-ruby that referenced this pull request Jan 23, 2026
@algolia-bot @sbellone
docs: authentication type can't be updated (generated)
2dd989a 
algolia/api-clients-automation#5824

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Sylvain Bellone <sylvain.bellone@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-scala that referenced this pull request Jan 23, 2026
@algolia-bot @sbellone
docs: authentication type can't be updated (generated)
af8add0 
algolia/api-clients-automation#5824

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Sylvain Bellone <sylvain.bellone@algolia.com>
algolia-bot added a commit to algolia/algoliasearch-client-swift that referenced this pull request Jan 23, 2026
@algolia-bot @sbellone
docs: authentication type can't be updated (generated)
64605b2 
algolia/api-clients-automation#5824

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Sylvain Bellone <sylvain.bellone@algolia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fluf22 Fluf22 Fluf22 approved these changes

@morganleroi morganleroi Awaiting requested review from morganleroi morganleroi is a code owner automatically assigned from algolia/api-clients-automation

@eric-zaharia eric-zaharia Awaiting requested review from eric-zaharia eric-zaharia is a code owner automatically assigned from algolia/api-clients-automation

Assignees

@sbellone sbellone

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sbellone @algolia-bot @Fluf22