Merged
Conversation
Haroenv
commented
Nov 2, 2020
eunjae-lee
suggested changes
Nov 2, 2020
Contributor
eunjae-lee
left a comment
There was a problem hiding this comment.
The tests are failing.
Haroenv
commented
Nov 2, 2020
yarn.lock
Outdated
| # yarn lockfile v1 | ||
|
|
||
|
|
||
| "@algolia/cache-browser-local-storage@4.5.1": |
Contributor
Author
There was a problem hiding this comment.
these seem to be added by shipjs not updating all versions (of dependencies), let's see what's different than in the script before
it's causing the test:build to fail 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request prepares the following release:
4.5.1→4.6.0Release Summary
This is going to be published with the following command:
Merging Instructions
When merging this pull request, you need to Squash and merge and make sure that the title starts with
chore: release v4.6.0.See details
After that, a commit
chore: release v4.6.0will be added and you or your CI can runshipjs triggerto trigger the release based on the commit.This pull request is automatically generated by Ship.js.