Auto detect proxy from environments#649
Merged
Merged
Conversation
algesten
requested changes
Aug 11, 2023
| ); | ||
| None | ||
| } | ||
|
|
Boshen
pushed a commit
to oxc-project/oxc
that referenced
this pull request
Aug 15, 2023
detect `HTTP_PROXY/HTTPS_PROXY/ALL_PROXY` environments automatically, since visiting https://raw.githubusercontent.com sometimes need proxy, upstream PR [algesten/ureq#649](algesten/ureq#649)
algesten
approved these changes
Sep 30, 2023
Owner
|
Thanks for the work in this PR! |
This was referenced Nov 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solve #322
Just like reqwest, auto detect proxy from
ALL_PROXY/HTTPS_PROXY/HTTP_PROXYreqwest::proxy.rsAdd
AgentBuilder::no_proxyif someone don't want to use system's proxy