select MIC algorithm using Disposition-Notification-Options header#20
Merged
select MIC algorithm using Disposition-Notification-Options header#20
Conversation
added 4 commits
December 26, 2022 17:57
…specific can re-use parts of this as new cases arise & refactor as more is learned. just focusing on the specific at hand for right now, & in a way that won't require public API changes in the future.
added 7 commits
January 4, 2023 09:23
in expected usage, we'll do validation before passing algorithm name to Message. so we should only be using default if client does not specify an algorithm. if client specified an unknown algorithm, & we instead defaulted to sha256, that's certain to result in a MIC mismatch & a failed transmission - but the silent fallback will make the issue harder to troubleshoot. so better to raise & solve the issue at the source.
examples: /Users/alexdean/.rvm/rubies/ruby-2.6.4/lib/ruby/2.6.0/net/protocol.rb:30: warning: method redefined; discarding old protocol_param /Users/alexdean/.rvm/gems/ruby-2.6.4/gems/net-protocol-0.2.1/lib/net/protocol.rb:32: warning: previous definition of protocol_param was here /Users/alexdean/.rvm/rubies/ruby-2.6.4/lib/ruby/2.6.0/net/protocol.rb:38: warning: method redefined; discarding old ssl_socket_connect /Users/alexdean/.rvm/gems/ruby-2.6.4/gems/net-protocol-0.2.1/lib/net/protocol.rb:40: warning: previous definition of ssl_socket_connect was here /Users/alexdean/.rvm/rubies/ruby-2.6.4/lib/ruby/2.6.0/net/protocol.rb:66: warning: already initialized constant Net::ProtocRetryError /Users/alexdean/.rvm/gems/ruby-2.6.4/gems/net-protocol-0.2.1/lib/net/protocol.rb:68: warning: previous definition of ProtocRetryError was here
$ bundle exec rake test ... snip ... test/client_test.rb:160: warning: assigned but unused variable - file_name_received_by_bob test/client_test.rb:161: warning: assigned but unused variable - file_content_received_by_bob test/client_test.rb:177: warning: assigned but unused variable - file_name_received_by_bob test/client_test.rb:178: warning: assigned but unused variable - file_content_received_by_bob test/server_test.rb:31: warning: assigned but unused variable - status test/server_test.rb:66: warning: assigned but unused variable - status
leftovers from initial attempt to handle many different kinds of headers. not needed now that this class is only focused on a single header type.
alexdean
pushed a commit
that referenced
this pull request
Feb 24, 2023
in case partner cares about 'sha-256' vs 'sha256' when evaluating MDNs we build refs #20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #19