Feature geometry api #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update tests to also verify TypeName.
…le coordinate transformation function. This change does not impose or demand the use of a particular re-projection library, that part is left to the consumer of this library to fill in.
Also document the (frankly) bizarre formatting convention of this bounding box array. It's not [minX, minY, maxX, maxY] as one might expect, it's [minY, minX, maxY, maxX]
- Constant-ify all usages of geometry type string literals with the GeometryType class - Add message for NotImplementedExceptions thrown for unknown/unsupported geometry types - Fix GeometryCollection failing to be created from DbGeometry if it has component LineStrings or MultiLineStrings - Fix missing casts on transformation of any multi- geometry type - Add unit test for DbGeometry -> GeometryCollection round tripping - Add unit tests for geometry transformation using a simple displacement transform function All WKT strings used in these tests sourced from the Wikipedia article about WKT: https://en.wikipedia.org/wiki/Well-known_text
alatas
added a commit
that referenced
this pull request
Jan 12, 2017
additions to @jumpinjackie's changes #11 -removed unnecessary imports, files, "Me" and other keywords -removed base interface implementatation and converted all generic base classes to non-generic -combined transform functions together and formatted -added serialize function with jsonoutput settings -base geom/geog factory functions converted to non-generic and shorthened with reflection -added props to transformexception -converted to vs2015 -changed unit tests according to lib changes
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the IGeoJsonGeometry interface to have more utility than being just a marker interface for JSON serialization:
Also included is some fixes:
Also included is unit tests covering the transformation functionality and verifying the DbGeometry -> GeometryCollection conversion supports all valid component geometry types