Merged
Conversation
If the sink in a duplex does not end until the source ends, we need to end the pushable stream used to propagate errors when the source ends, otherwise the returned merged source never ends and everything hangs.
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 303 344 +41
Branches 49 58 +9
=========================================
+ Hits 303 344 +41
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
github-actions bot
pushed a commit
that referenced
this pull request
Jan 15, 2022
### [2.0.3](v2.0.2...v2.0.3) (2022-01-15) ### Bug Fixes * support goodbye sources ([#10](#10)) ([1e4bc73](1e4bc73))
|
🎉 This PR is included in version 2.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the sink in a duplex does not end until the source ends, we need to end the pushable stream used to propagate errors when the source ends, otherwise the returned merged source never ends and everything hangs.