Require all zero argument UDFs use Signature::Nullary, improve error messages
#22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rgument functions - Updated the `Simple0ArgsScalarUDF` to utilize `Signature::nullary` instead of `Signature::exact`. - Modified tests to reflect the change in signature handling for zero-argument functions. - Enhanced error messages in type coercion functions to clarify the requirement for nullary signatures. - Cleaned up redundant checks and improved code readability in the type coercion logic. This change improves consistency in how zero-argument functions are defined and validated across the codebase.
Signed-off-by: Jay Zhan <jayzhan211@gmail.com>
jayzhan211
commented
Dec 22, 2024
| use super::*; | ||
|
|
||
| #[test] | ||
| fn supports_zero_argument_tests() { |
Signature::Nullary, improve error messages
alamb
approved these changes
Dec 22, 2024
Owner
alamb
left a comment
There was a problem hiding this comment.
Thank you @jayzhan211 -- makes sense to me. I will merge this PR and update the description
alamb
added a commit
that referenced
this pull request
Apr 7, 2025
* Improve doc comments * Apply suggestions from code review --------- Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
alamb
added a commit
that referenced
this pull request
Apr 17, 2025
… them (apache#15566) * ExecutionPlan: add APIs for filter pushdown & optimizer rule to apply them * wip * fix tests * fix * fix * fix doc * fix doc * Improve doc comments of `filter-pushdown-apis` (#22) * Improve doc comments * Apply suggestions from code review --------- Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> * simplify according to pr feedback * Add missing file * Add tests * pipe config in * docstrings * Update datafusion/physical-plan/src/filter_pushdown.rs * fix * fix * fmt * fix doc * add example usage of config * fix test * convert exec API and optimizer rule * re-add docs * dbg * dbg 2 * avoid clones * part 3 * fix lint * tests pass * Update filter.rs * update projection tests * update slt files * fix * fix references * improve impls and update tests * apply stop logic * update slt's * update other tests * minor * rename modules to match logical optimizer, tweak docs --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> Co-authored-by: berkaysynnada <berkay.sahin@synnada.ai> Co-authored-by: Berkay Şahin <124376117+berkaysynnada@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Signature::Nullary, improve error messages apache/datafusion#13871