[ToBF] 18.04.23 Refinement#457
Merged
nausharipov merged 15 commits intotobf-all-tasks-28-03-23from Apr 24, 2023
Merged
Conversation
alexeyinkin
suggested changes
Apr 18, 2023
| children: [ | ||
| ContentTreeWidget(controller: tourNotifier.contentTreeController), | ||
| Expanded( | ||
| child: DefaultTabController( |
There was a problem hiding this comment.
Make
enum TourView {
content,
playground,
}Use the stuff from keyed_collection_widgets with those keys.
alexeyinkin
suggested changes
Apr 20, 2023
| child: DefaultTabController( | ||
| length: 2, | ||
| child: DefaultKeyedTabController.fromKeys( | ||
| keys: const [TourView.content, TourView.playground], |
There was a problem hiding this comment.
Suggested change
| keys: const [TourView.content, TourView.playground], | |
| keys: TourView.values, |
| Tab(text: 'Playground'), | ||
| ], | ||
| KeyedTabBar.withDefaultController<TourView>( | ||
| tabs: { |
There was a problem hiding this comment.
Use enum_map for compile-time guarantee that all values are present.
Same for TabBarView.children.
alexeyinkin
reviewed
Apr 21, 2023
| String _sdkId; | ||
| Sdk _sdk; | ||
| List<String> _treeIds; | ||
| // TODO(nausharipov) review: delete the todo? |
| import 'path.dart'; | ||
|
|
||
| class WelcomeNotifier extends ChangeNotifier with PageStateMixin<void> { | ||
| // TODO(nausharipov) review: delete the todo? |
| complexity: result.complexity, | ||
| files: result.files, | ||
| name: 'User Snippet', | ||
| // TODO(nausharipov) review: delete the todo? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clearing TODOs.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.