Delete local user progress on account deletion (#25255) (#25283)#449
Merged
nausharipov merged 3 commits intotobf-all-tasks-28-03-23from Mar 31, 2023
Merged
Conversation
alexeyinkin
suggested changes
Mar 31, 2023
| Future<void> deleteAccount() async { | ||
| try { | ||
| await client.postDeleteUserProgress(); | ||
| // TODO(nausharipov) review: is there a better place for this? |
There was a problem hiding this comment.
Add AccountDeletionListener, notify all listeners here.
Add final _accountDeletionListeners = <AccountDeletionListener>[];
With methods like beforeAccountDeleted or afterAccountDeleted. Likely we should do "before...". Those methods should be async, we should wait for them to complete.
Collaborator
Author
There was a problem hiding this comment.
The implementation added extra code, which is not necessary for now. Added a comment.
Comment on lines
+177
to
+178
| await _localStorageUserProgressRepository.deleteUserProgress(); | ||
| await _cloudUserProgressRepository.deleteUserProgress(); |
Amar3tto
added a commit
that referenced
this pull request
Feb 13, 2025
Add try catch for getting schema information
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete local user progress on account deletion.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.