TOBF (ToB frontend): welcome screen#226
Merged
alexeyinkin merged 56 commits intotob_frontfrom Aug 19, 2022
Merged
Conversation
alexeyinkin
reviewed
Aug 5, 2022
alexeyinkin
reviewed
Aug 5, 2022
alexeyinkin
reviewed
Aug 5, 2022
alexeyinkin
reviewed
Aug 5, 2022
alexeyinkin
reviewed
Aug 5, 2022
alexeyinkin
reviewed
Aug 5, 2022
alexeyinkin
reviewed
Aug 5, 2022
alexeyinkin
reviewed
Aug 5, 2022
learning/tour-of-beam/frontend/lib/components/sign_in_button.dart
Outdated
Show resolved
Hide resolved
alexeyinkin
reviewed
Aug 5, 2022
learning/tour-of-beam/frontend/lib/config/theme/switch_notifier.dart
Outdated
Show resolved
Hide resolved
alexeyinkin
reviewed
Aug 5, 2022
learning/tour-of-beam/frontend/lib/config/theme/switch_notifier.dart
Outdated
Show resolved
Hide resolved
alexeyinkin
reviewed
Aug 5, 2022
alexeyinkin
reviewed
Aug 5, 2022
alexeyinkin
reviewed
Aug 5, 2022
alexeyinkin
reviewed
Aug 5, 2022
|
Good candidates for a common package:
|
alexeyinkin
reviewed
Aug 17, 2022
added 4 commits
August 18, 2022 08:13
tour-of-beam in build.gradle.kts
alexeyinkin
reviewed
Aug 19, 2022
|
Please do not resolve conversations yourself. Unresolved ones helps a reviewer to see the outstanding issues. |
alexeyinkin
reviewed
Aug 19, 2022
| final String selectedSdk; | ||
| final String value; | ||
| final String groupValue; | ||
| final void Function()? onChanged; |
There was a problem hiding this comment.
final ValueChanged<String> onChanged;
Collaborator
Author
There was a problem hiding this comment.
The argument type 'void Function(String)' can't be assigned to the parameter type 'void Function()?'.
Also, I expected the value to be changed with bloc. Are you sure we need an onChanged function with a parameter?
I think a function without parameters and with a name like "changeValue" might fit better here.
Collaborator
Author
There was a problem hiding this comment.
I'm also not sure about the value and groupValue naming: they presume that it's a general widget, but ours is a specific widget called SdkButton.
nausharipov
added a commit
that referenced
this pull request
Aug 19, 2022
* theme setup * Replaced ThemeProvider with ThemeSwitchNotifier * header with theme mode switcher and logo * page container with header & footer * theme mode tests * renamed the directory to tour-of-beam * compressed beam_logo.png * added missing license comments * rudimentary layout of the first screen * review comments fixes #1 * moved notifyListeners inside then * responsive todo * split into 2 simple functions * deleted redundant constants & replaced 2018 text theme with 2021 * styling refinement * home screen layout * clickable sign in text * font weights fix * removed _getBaseFontTheme function * fixed border and bg color * color fixes * difficulty component * _LastModuleBody * todo in test * footer border * fixed overflows * replaced Project prefix with Tob * replaced then with await * inferred type * started translation of the home screen * sorted translations * Complexity comments * comment fixes * home screen translations * sign in overlay * import fix * integration test does not fail * playground_components package with dismissible_overlay * missing license * removed _dots from build * widgets refinement * renamed home screen to welcome screen * deleted copyWith * _SdkButton * trailing comma & pubspec formatting * license and lints * license * removed license from .metadata * pubspec formatting * total lints update * changed from tour_of_beam to tour-of-beam in build.gradle.kts * license check * _SdkButton mimics Radio button * renamed MyApp to TourOfBeamApp * onChanged mimics Radio button Co-authored-by: darkhan.nausharipov <darkhan.nausharipov@kzn.akvelon.com>
4 tasks
olehborysevych
pushed a commit
that referenced
this pull request
Sep 5, 2022
* Tour of Beam frontend blank project * TOBF (ToB frontend): welcome screen (#226) * theme setup * Replaced ThemeProvider with ThemeSwitchNotifier * header with theme mode switcher and logo * page container with header & footer * theme mode tests * renamed the directory to tour-of-beam * compressed beam_logo.png * added missing license comments * rudimentary layout of the first screen * review comments fixes #1 * moved notifyListeners inside then * responsive todo * split into 2 simple functions * deleted redundant constants & replaced 2018 text theme with 2021 * styling refinement * home screen layout * clickable sign in text * font weights fix * removed _getBaseFontTheme function * fixed border and bg color * color fixes * difficulty component * _LastModuleBody * todo in test * footer border * fixed overflows * replaced Project prefix with Tob * replaced then with await * inferred type * started translation of the home screen * sorted translations * Complexity comments * comment fixes * home screen translations * sign in overlay * import fix * integration test does not fail * playground_components package with dismissible_overlay * missing license * removed _dots from build * widgets refinement * renamed home screen to welcome screen * deleted copyWith * _SdkButton * trailing comma & pubspec formatting * license and lints * license * removed license from .metadata * pubspec formatting * total lints update * changed from tour_of_beam to tour-of-beam in build.gradle.kts * license check * _SdkButton mimics Radio button * renamed MyApp to TourOfBeamApp * onChanged mimics Radio button Co-authored-by: darkhan.nausharipov <darkhan.nausharipov@kzn.akvelon.com> * removed whitespace from readme (issue-22583) * renamed "content" to "child" to mimic widgets * README in tour-of-beam * translation path rename, grey dot with opacity, footer link text style * report issue in github, grey dot color * table instead of row to clip the laptop image * horizontalHalves & verticalHalves * cropped laptop image * row in an expensive intrinsic height * laptop image in the bottom * ScreenBreakpoints * intrinsic height is not needed! * _WideWelcome and _NarrowWelcome * draft readme * blank line in readme * removed irrelevant info from readme * removed whitespace Co-authored-by: Alexey Inkin <alexey.inkin@akvelon.com> Co-authored-by: darkhan.nausharipov <darkhan.nausharipov@kzn.akvelon.com> Co-authored-by: alexeyinkin <leha@inkin.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apache#22583 Project setup and the welcome screen.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.