Added bigtable write to template#1
Merged
ilya-kozyrev merged 4 commits intoProtegrityIntegrationTemplatefrom Dec 7, 2020
Merged
Added bigtable write to template#1ilya-kozyrev merged 4 commits intoProtegrityIntegrationTemplatefrom
ilya-kozyrev merged 4 commits intoProtegrityIntegrationTemplatefrom
Conversation
5bf6f21 to
8d717b8
Compare
8d717b8 to
20a2213
Compare
KhaninArtur
suggested changes
Dec 7, 2020
...on/src/main/java/com/google/cloud/teleport/v2/options/ProtegrityDataTokenizationOptions.java
Outdated
Show resolved
Hide resolved
...ization/src/main/java/com/google/cloud/teleport/v2/templates/ProtegrityDataTokenization.java
Outdated
Show resolved
Hide resolved
Comment on lines
193
to
202
There was a problem hiding this comment.
Is there any way to make this transform and/or writing to BT failsafe?
Author
There was a problem hiding this comment.
I think making this failsafe should be in a separate PR to reduce PR size and possible merge conflicts
There was a problem hiding this comment.
Sounds fair, please, take care of this after merging this PR.
20a2213 to
dcd3f5e
Compare
KhaninArtur
suggested changes
Dec 7, 2020
...ta-tokenization/src/main/java/com/google/cloud/teleport/v2/transforms/io/BigTableOutput.java
Outdated
Show resolved
Hide resolved
...ta-tokenization/src/main/java/com/google/cloud/teleport/v2/transforms/io/BigTableOutput.java
Outdated
Show resolved
Hide resolved
KhaninArtur
approved these changes
Dec 7, 2020
ilya-kozyrev
suggested changes
Dec 7, 2020
...y-data-tokenization/src/main/java/com/google/cloud/teleport/v2/transforms/io/BigTableIO.java
Show resolved
Hide resolved
elizaveta-lomteva
pushed a commit
that referenced
this pull request
May 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.