Fix fatal error during feed discovery when content is null#627
Merged
Conversation
When wp_safe_remote_get receives a redirect it doesn't follow (e.g. cross-domain), the response code is 3xx and $content stays null. On PHP 8.4, passing null to SimplePie::set_raw_data() throws a TypeError fatal error. - Add null guards in SimplePie and Microformats parsers - Detect unfollowed redirects and show the user a helpful message with the redirect target URL
Contributor
Test this PR in WordPress PlaygroundYou can test this pull request directly in WordPress Playground: This will install and activate the plugin with the changes from this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #619
Summary
wp_safe_remote_getreceives a cross-domain redirect it doesn't follow, the response is 3xx and$contentstaysnull. On PHP 8.4, passingnulltoSimplePie::set_raw_data()throws aTypeErrorfatal, causing a "critical error" page.Test plan
https://web.brid.gy/currenttime.tvon the Add Friend page and click Next