Skip to content

Implement reblogging#2

Merged
akirk merged 5 commits intomainfrom
implement-reblogging
Apr 6, 2023
Merged

Implement reblogging#2
akirk merged 5 commits intomainfrom
implement-reblogging

Conversation

@akirk
Copy link
Copy Markdown
Owner

@akirk akirk commented Apr 5, 2023

This will require Friends 2.4.1.

@akirk akirk merged commit 9f1eaca into main Apr 6, 2023
@eiland-asbl eiland-asbl mentioned this pull request Feb 19, 2024
@akirk akirk deleted the implement-reblogging branch May 22, 2024 14:07
akirk added a commit that referenced this pull request Apr 4, 2026
…diverse posts

When replying to a remote post (resolved via search), the in_reply_to_id
filter maps the numeric ID back to the original URL. api_submit_comment
was blindly setting comment_post_ID to that URL string and calling
wp_insert_comment() with invalid data, triggering:
  preg_match(): Passing null to parameter #2 ($subject)
The reply was also never federated since no proper post was created.

Fix api_submit_comment to skip comment creation when comment_post_ID
doesn't correspond to a real local post, falling through to api_submit_post.

Fix prepare_post_data to handle a URL-based in_reply_to_id by prepending
an activitypub/reply block to the post content (rather than setting an
invalid post_parent), so the ActivityPub plugin can federate the reply
to the correct remote URL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant