Merged
Conversation
Open
akirk
added a commit
that referenced
this pull request
Apr 4, 2026
…diverse posts When replying to a remote post (resolved via search), the in_reply_to_id filter maps the numeric ID back to the original URL. api_submit_comment was blindly setting comment_post_ID to that URL string and calling wp_insert_comment() with invalid data, triggering: preg_match(): Passing null to parameter #2 ($subject) The reply was also never federated since no proper post was created. Fix api_submit_comment to skip comment creation when comment_post_ID doesn't correspond to a real local post, falling through to api_submit_post. Fix prepare_post_data to handle a URL-based in_reply_to_id by prepending an activitypub/reply block to the post content (rather than setting an invalid post_parent), so the ActivityPub plugin can federate the reply to the correct remote URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will require Friends 2.4.1.