updating plotBEMIO for multiple hydro solutions #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akeeste
reviewed
Feb 15, 2022
Owner
akeeste
left a comment
There was a problem hiding this comment.
@kmruehl Thanks for this fix! A few questions:
- What was the to the AQWA hydrodata? Is this going to conflict with the dev branch now?
- what is readBEMIOH5 doing? I changed a few of these functions in my PR and am getting mixed up now
I don't think Github is comparing these files correctly. It is showing a lot of changes that should have already been incorporated in your last PR
11b8d52 to
cc92f64
Compare
Collaborator
Author
This is from Jeff's PR and need to be removed prior to dev merge, but needed now for testing
Moved this function from bodyClass to source/functions/BEMIO, where we want it long-term. It should be called from the bodyClass prior to merging with dev
|
akeeste
added a commit
that referenced
this pull request
Feb 21, 2022
* add util functions for renaming * rename BEMIO functions * rename BEMIO files and fix plotBEMIO name * update BEMIO functions internal variable naming * remove redundant writeH5 functions. All incorporated into writeH5.m * remove redundant wave number function * remove renaming scripts * remove bemio.m, add readme directing users to bemio examples * remove references to specific BEM codes * rename writeH5 to wecsim specific name and update internal functions * formatting and fix typo in plotBEMIO * update all calls to writeBEMIOH5.m * simplify and rename loadH5 function. Change to use h5read and reveserDimensionOrder * updating plotBEMIO for multiple hydro solutions (#11) * Fix AQWA data for sphere, ellipsoid, and WEC3 * working on compare BEM hydro data * combined added mass BEM * compare added mass complete * removing duplicate files * updating plot radiation damping * updating plot radiation irf * updating plot exc mag * updated plot excitation phase and irf * updated plot bemio scripts * reverting bemio examples * updating plot functions to camelCase * resolving conflicts * updating compare plots for multiple body wecs * extending plotAddedMass to multiple hydro datasets * extending plotRadDamping to multiple hydro datasets * adding extensible plot rad irf * adding exc mag and phase * updaing exc irf plot for mult bemio results * resolve radiationIRF SS bug * cleaning up compareBEM * resolving nested varargin for plotAddedMass * resolving nested varargin for all plots * nested varargin bug resolved * updating compareBEM to camelCase * resolving plotExcIRF bug * removing pngs Co-authored-by: jtgrasb <jtgrasb@sandia.gov> Co-authored-by: Adam Keester <72414466+akeeste@users.noreply.github.com> * remove mat files * revert AQWA files to dev version * remove question mark character * replace bodyClass loadH5File with readBEMIOH5 and loadHydroData * update catch for variable arguments in plotX functions * refactor BEMIO plotting functions and only take varargin * add BEMIO png files to gitignore * make FormatPlot camel case * remove clear all and close all from bemio examples * force rename capitalization in git * remove BEMIO pngs * fix comment typos * remove compareBEM * update BEMIO function names in documentation * adding compareBEMIO example * adding NEMOH to compareBEMIO and cleanup * adding testCompareBEMIO Co-authored-by: Kelley Ruehl <kmruehl@sandia.gov> Co-authored-by: jtgrasb <jtgrasb@sandia.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Compare_BEM functionality. @akeeste this should resolve the nested varargin bug.