Conversation
Member
Author
|
Will also need to fix the aiohttp testing in another PR |
CodSpeed Performance ReportMerging #1609 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Pull request overview
This PR drops Python 3.9 support and establishes Python 3.10 as the new minimum supported version. The primary motivation is to fix CI issues and adopt modern Python type annotation syntax.
- Converts type annotations from
Union[X, Y]to theX | Ysyntax (PEP 604) in function signatures and return types - Removes Python 3.9 and PyPy 3.9 from CI test matrix
- Updates package metadata and pre-commit configuration to reflect the new minimum Python version
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| yarl/_url.py | Converted Union type annotations to pipe syntax in function signatures, method parameters, and property return types |
| yarl/_quoting_py.py | Updated Union type annotations to pipe syntax in Quoter and Unquoter class methods; removed Union import |
| yarl/_quoters.py | Converted Union type annotation to pipe syntax in human_quote function; removed Union import |
| yarl/_query.py | Updated Union type annotations to pipe syntax in function signatures and variable annotations |
| yarl/_parse.py | Converted Union type annotations to pipe syntax in split_netloc and make_netloc functions; removed Union import |
| tests/test_update_query.py | Updated test function signatures from Union/Optional to pipe syntax; removed typing imports |
| tests/test_quoting.py | Converted fixture return type annotations to pipe syntax; removed Union import |
| setup.cfg | Removed Python 3.9 classifier and updated python_requires to >=3.10 |
| CHANGES/1609.packaging.rst | Added change note documenting the removal of Python 3.9 support |
| .pre-commit-config.yaml | Updated pyupgrade args from --py39-plus to --py310-plus |
| .github/workflows/ci-cd.yml | Removed Python 3.9 and PyPy 3.9 from test matrix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1609 +/- ##
==========================================
+ Coverage 97.95% 99.57% +1.62%
==========================================
Files 29 29
Lines 5860 5877 +17
Branches 44 266 +222
==========================================
+ Hits 5740 5852 +112
+ Misses 76 21 -55
+ Partials 44 4 -40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Drop Python 3.9 support. Python 3.10 is now the minimum supported version.
Are there changes in behavior for the user?
Users on Python 3.9 will need to upgrade to Python 3.10+.
Related issue number
N/A
Checklist
CHANGES/1609.packaging.rst