Conversation
CodSpeed Performance ReportMerging #1607 will degrade performances by 25.46%Comparing Summary
Benchmarks breakdown
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1607 +/- ##
==========================================
- Coverage 99.57% 99.37% -0.20%
==========================================
Files 29 30 +1
Lines 5877 5940 +63
Branches 266 282 +16
==========================================
+ Hits 5852 5903 +51
- Misses 21 22 +1
- Partials 4 15 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| try: | ||
| from pydantic import GetCoreSchemaHandler, GetJsonSchemaHandler | ||
| from pydantic.json_schema import JsonSchemaValue | ||
| from pydantic_core import core_schema | ||
|
|
||
| HAS_PYDANTIC = True | ||
| except ImportError: | ||
| HAS_PYDANTIC = False |
There was a problem hiding this comment.
Excellent. I was very worried that pydantic was going to be required when I saw this pop up. For context Home Assistant had a 2+ year struggle to migrate from pydantic 1 to 2 because of the need to align 50+ downstream libraries and the sheer number of breaking changes.
|
LGTM. I'll look at fixing the CI later today |
|
CI is fixed. The failures are legitimate build issues with this PR now. |
|
the macos / windows 3.13t tests are failing because of the 5m timeout and there are no pydantic wheels for those archs so it has to build them |
|
Let's run pydantic tests for Linux only on CI, it should be enough |
What do these changes do?
yarl.URLcould be used inpydanticmodels without a boilrplate.Are there changes in behavior for the user?
The change doesn't break any existing code but helps with URL serialization/deserialization of
pydanticmodels if the library was installed by user.Related issue number
None
Checklist