📦 Normalize tmp dir path in built artifacts#1591
Merged
webknjaz merged 2 commits intoaio-libs:masterfrom Oct 30, 2025
Merged
Conversation
This patch makes sure that the random temporary directory path does not end up in the built C-extensions. The effect is that downstreams will get reproducible build results.
CodSpeed Performance ReportMerging #1591 will not alter performanceComparing Summary
|
webknjaz
added a commit
to webknjaz/yarl
that referenced
this pull request
Oct 30, 2025
d25bef6 to
7b651df
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1591 +/- ##
=======================================
Coverage 99.57% 99.57%
=======================================
Files 29 29
Lines 5872 5881 +9
Branches 266 266
=======================================
+ Hits 5847 5856 +9
Misses 21 21
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 task
|
This doesn't appear to work: I had to set |
Member
Author
|
@rossburton what did you expect? I thought you wanted static paths so I've set it up to replace paths that contain random substrings with a path to the source checkout. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch makes sure that the random temporary directory path does not end up in the built C-extensions. The effect is that downstreams will get reproducible build results.
Are there changes in behavior for the user?
Not really. It's just a different less random string that might end up in the built C-extensions.
Related issue number
Checklist