🧪 Convert codspeed job to reusable workflow#1587
Merged
webknjaz merged 7 commits intoaio-libs:masterfrom Oct 28, 2025
Merged
Conversation
7b04a27 to
218eaaa
Compare
This is needed for GHA testing to be able to run from tarballs.
2c44129 to
0ba30ce
Compare
CodSpeed Performance ReportMerging #1587 will improve performances by ×27Comparing Summary
Benchmarks breakdown
|
webknjaz
added a commit
to webknjaz/yarl
that referenced
this pull request
Oct 27, 2025
bdraco
reviewed
Oct 28, 2025
bdraco
reviewed
Oct 28, 2025
Co-Authored-By: J. Nick Koston <nick@koston.org>
webknjaz
added a commit
to webknjaz/yarl
that referenced
this pull request
Oct 28, 2025
9c9c17f to
3c3cc3d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1587 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 29 29
Lines 5835 5835
Branches 266 266
=======================================
Hits 5812 5812
Misses 19 19
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
It is currently unable to retrieve the commit details from GitHub-set environment variables. Ref: CodSpeedHQ/codspeed#144
They are typically done after 1 min 20 sec.
3c3cc3d to
764e3d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The Codspeed job has been converted into a reusable workflow. It is now called in one of two modes in the main one. In release automation, the benchmark measures the performance of the dists about to be released to PyPI. In all other cases, the job builds the project from source and does benchmarking on that. This means that now both release and pull request CI runs test the optimized builds of the C-extension.
Are there changes in behavior for the user?
Nope. Only for the contributors. The benchmark numbers will be aligned across PR and release builds.
Related issue number
N/A
Checklist