Improve performance of path functions on cache miss#1443
Conversation
CodSpeed Performance ReportMerging #1443 will improve performances by 84.24%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1443 +/- ##
==========================================
+ Coverage 96.13% 96.14% +0.01%
==========================================
Files 31 31
Lines 5948 5970 +22
Branches 362 364 +2
==========================================
+ Hits 5718 5740 +22
Misses 204 204
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…to skip_quoting_empty_and_slash
|
Its not going to show any difference because the cached_property is already cached and it only does it once
|
|
Probably should do a new release of |
|
Its actually unlikely to make much difference since with the caching improvements (unreleased due to the publish issue) its so much more likely to be cached anyways. |
We did not have the ability to write benchmarks that benchmarked the first hit because propcache did not expose the wrapped function until 0.2.1 This will give us a better idea if #1443 is worth it
|
Well I guess it is worth it |
There were a few places we called the quoter when we know its never going to do anything.
On cache miss for
.query_string, this will help a bit.However its not possible to benchmark right now because of #1443 (comment)We can avoid some of the property accesses internally as well which should speed these up a bit. Since the
aiohttpurl dispatcher callspath_safethere is a much larger chance we get a cache miss so it makes sense to optimize this one a bit.