Avoid caching the constructed URL when altering the query string#1436
Merged
Avoid caching the constructed URL when altering the query string#1436
Conversation
When a query string is passed, the hit rate on the cache goes way down. Its best not to cache the query calls because the data is far more likely to change for query values
Merged
bdraco
commented
Nov 29, 2024
CodSpeed Performance ReportMerging #1436 will degrade performances by 24.96%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1436 +/- ##
=======================================
Coverage 96.11% 96.11%
=======================================
Files 31 31
Lines 5873 5876 +3
Branches 349 349
=======================================
+ Hits 5645 5648 +3
Misses 202 202
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
Author
|
Once its primed the miss rate barely increases now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a query string is passed, the hit rate on the cache goes way down. Its best not to cache the query calls because the data is far more likely to change for query values.
This will show a reduction on the benchmark but its no different than it was before #1434