Drop 3.13t support#1326
Conversation
|
@ngoldbaum Glad to see you here, seems some other people might be busy so I'll help you with the reviewing process. |
Vizonex
left a comment
There was a problem hiding this comment.
All of this looks good might need to add a comment or two about why 3.13t is being removed but other than that I approve of this pull request.
Vizonex
left a comment
There was a problem hiding this comment.
That should be good enough now.
Vizonex
left a comment
There was a problem hiding this comment.
Waiting for feedback about the changes I let everyone on the matrix know that a workflow was left hanging.
webknjaz
left a comment
There was a problem hiding this comment.
Apart from the change note, looks good. I'll wait for Nick and Sam to take a look before proceeding.
There was a problem hiding this comment.
Could you symlink think to packaging? Also, I'm not sure if this counts as breaking.
cc @Dreamsorcerer @bdraco WDYT?
There was a problem hiding this comment.
Thanks - I misunderstood what you were referring to with the symlink. See latest push.
There was a problem hiding this comment.
Except it looks like towncrier doesn't like symlinks, so I just removed the breaking note and called it packaging.
There was a problem hiding this comment.
@ngoldbaum Towncrier works with symlinks just fine. This replaces having two text files with exactly the same contents 🤷♂️
The failure in your previous commit was caused by an HTTP 500 when uploading MyPy type preciseness coverage to Coveralls: https://github.com/aio-libs/multidict/actions/runs/25672626609/job/75361690773?pr=1326#step:8:232
There was a problem hiding this comment.
I'm sure restarting that job will make it green..
bdraco
left a comment
There was a problem hiding this comment.
LGTM once other comments are addressed. clearly 3.13t was not ready for production use so removing wheels is reasonable
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
|
Sorry for taking two weeks to click the button! I think this is ready now. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1326 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 28 28
Lines 3602 3602
Branches 265 265
=======================================
Hits 3597 3597
Misses 3 3
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Good because we were worried that you just left on an hiatus, if I don't see anything new needing to be changed I'll request for this PR to be merged. |
| @@ -0,0 +1 @@ | |||
| CHANGES/1326.breaking.rst No newline at end of file | |||
There was a problem hiding this comment.
@ngoldbaum the problem here was that you've added a symlink relative to the repo root and so any tooling resolving it, would search for CHANGES/CHANGES/1326.packaging.rst. The correct way would be running ln -s in the CHANGES/ dir so that the relative link points to just 1326.packaging.rst w/o the dir prefix...
There was a problem hiding this comment.
Thanks for explaining, see latest commit.
webknjaz
left a comment
There was a problem hiding this comment.
Not sure if we need to also have this filed under “breaking changes” (see the old symlink discussion threads inline), but this looks good to me regardless.
- Remove `enable = ["cpython-freethreading"]` from `[tool.cibuildwheel]` in pyproject.toml (cibuildwheel 3.4 deprecated the option). - Replace the `- 3.13t` test matrix entry with an explanatory comment instead of silently dropping it. - Restructure the change note: real text lives in `CHANGES/223.packaging.rst`; `CHANGES/223.breaking.rst` is a symlink to it, mirroring the structure used in aio-libs/multidict#1326. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
What do these changes do?
See the note at https://cibuildwheel.pypa.io/en/stable/changelog/#v341 and pypa/cibuildwheel#2787.
The
cpython-freethreadingoption will be removed in the next release of cibuildwheel.I'm going through repositories on GitHub that enable this option and sending in PRs to disable it. Happy to answer questions about this. I also took the opportunity to drop 3.13t CI.
If you're curious why 3.13t support is going away so soon, see https://py-free-threading.github.io/ci/#building-free-threaded-wheels-with-cibuildwheel for further guidance.
Are there changes in behavior for the user?
The next release will not include cp313t wheel builds.
Checklist