Skip to content

Restore multidict internal state on exception during updating#1215

Merged
asvetlov merged 4 commits intoaio-libs:masterfrom
asvetlov:post-update
Jun 27, 2025
Merged

Restore multidict internal state on exception during updating#1215
asvetlov merged 4 commits intoaio-libs:masterfrom
asvetlov:post-update

Conversation

@asvetlov
Copy link
Member

@asvetlov asvetlov commented Jun 27, 2025

No description provided.

@asvetlov asvetlov requested a review from webknjaz as a code owner June 27, 2025 15:34
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jun 27, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 27, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1215 will degrade performances by 52.11%

Comparing asvetlov:post-update (8d3b618) with master (0b046c9)

Summary

⚡ 3 improvements
❌ 4 (👁 4) regressions
✅ 238 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
👁 test_cimultidict_getall_istr_hit[py] 183.5 ms 383.1 ms -52.11%
⚡ test_cimultidict_getall_istr_miss[py] 5.9 ms 3.1 ms +89.5%
👁 test_create_empty_multidict[ci-py] 55.2 µs 76.2 µs -27.61%
👁 test_create_empty_multidict[cs-py] 53.2 µs 73.6 µs -27.73%
⚡ test_create_multidict_with_items[ci-c] 104.5 µs 95.2 µs +9.87%
👁 test_multidict_getall_str_hit[ci-py] 184.1 ms 383.5 ms -51.99%
⚡ test_multidict_getall_str_miss[ci-py] 6.7 ms 3.4 ms +94.6%

@asvetlov asvetlov closed this Jun 27, 2025
@asvetlov asvetlov reopened this Jun 27, 2025
@codecov
Copy link

codecov bot commented Jun 27, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.38%. Comparing base (0b046c9) to head (8d3b618).
⚠️ Report is 17 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1215      +/-   ##
==========================================
+ Coverage   98.35%   98.38%   +0.03%     
==========================================
  Files          27       27              
  Lines        3961     3973      +12     
  Branches      721      730       +9     
==========================================
+ Hits         3896     3909      +13     
+ Misses         18       17       -1     
  Partials       47       47
Flag Coverage Δ
CI-GHA 98.38% <100.00%> (+0.03%) ⬆️
MyPy 80.44% <36.84%> (-0.04%) ⬇️
pytest 99.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@asvetlov asvetlov merged commit 50a58d4 into aio-libs:master Jun 27, 2025
63 of 64 checks passed
@asvetlov asvetlov deleted the post-update branch June 27, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees

No one assigned

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@asvetlov