Skip to content

Tune multidict docs#1205

Merged
asvetlov merged 4 commits intoaio-libs:masterfrom
asvetlov:docs
Jun 25, 2025
Merged

Tune multidict docs#1205
asvetlov merged 4 commits intoaio-libs:masterfrom
asvetlov:docs

Conversation

@asvetlov
Copy link
Member

@asvetlov asvetlov commented Jun 25, 2025

  1. Put extend() and update() docs in the same logical group to display bulk update methods together
  2. Mention kwargs as accepted argument for both extend() and update().

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jun 25, 2025
@asvetlov asvetlov marked this pull request as ready for review June 25, 2025 16:42
@asvetlov asvetlov requested a review from webknjaz as a code owner June 25, 2025 16:42
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 25, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1205 will degrade performances by 33.02%

Comparing asvetlov:docs (97471a4) with master (af83fc3)

Summary

⚡ 3 improvements
❌ 3 (👁 3) regressions
✅ 238 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ test_cimultidict_getall_istr_hit[py] 28.8 ms 16.6 ms +72.94%
👁 test_cimultidict_getall_istr_miss[py] 1.9 ms 2.4 ms -18.9%
⚡ test_multidict_getall_str_hit[ci-py] 28.7 ms 16.6 ms +73.39%
⚡ test_multidict_getall_str_hit[cs-py] 20.5 ms 15.9 ms +29.02%
👁 test_multidict_getall_str_miss[ci-py] 1.4 ms 2.1 ms -33.02%
👁 test_multidict_getall_str_miss[cs-py] 1.4 ms 1.5 ms -11.38%

@codecov
Copy link

codecov bot commented Jun 25, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.32%. Comparing base (af83fc3) to head (97471a4).
⚠️ Report is 29 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1205   +/-   ##
=======================================
  Coverage   98.32%   98.32%           
=======================================
  Files          27       27           
  Lines        3874     3874           
  Branches      706      706           
=======================================
  Hits         3809     3809           
  Misses         18       18           
  Partials       47       47
Flag Coverage Δ
CI-GHA 98.32% <ø> (ø)
MyPy 80.47% <ø> (ø)
pytest 99.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@asvetlov asvetlov merged commit 5715939 into aio-libs:master Jun 25, 2025
64 checks passed
@asvetlov asvetlov deleted the docs branch June 25, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees

No one assigned

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@asvetlov