Sync reusable-cibuildwheel.yml with upstream#1199
Conversation
CodSpeed Performance ReportMerging #1199 will improve performances by 15.27%Comparing Summary
Benchmarks breakdown
|
This will excersise building wheels entirely from source tarballs.
0653c0b to
07266a0
Compare
|
|
||
| name: Build wheel | ||
| name: >- | ||
| ❌ |
There was a problem hiding this comment.
Please describe why this name is so uncommon.
There was a problem hiding this comment.
It should show up in the sidebar with a clear message.
There was a problem hiding this comment.
Could you provide a screenshot please?
I see that message in a context where there is not a button to click.
There was a problem hiding this comment.
There was a problem hiding this comment.
I see the text on the left sidebar, but I don't see a button that I shouldn't click.
Don't get me wrong, if you had the reason to write the text -- I respect it.
My intention is only to understand why you wrote the text and what exactly I shouldn't click.
There was a problem hiding this comment.
Yes, that's a sidebar item, not a button. That page is never going to have any CI runs on it. And so I've been marking such pages as "don't click".
This is essentially the same concept I introduced in CPython with "modules" that are in-repo reusable workflows and aren't allowed to have any other triggers. Plus their filenames are prefixed per convention.
What do these changes do?
This patch includes setting input defaults for sdist-related fields and passing the sdist directly into
cibuildwheel. It also normalizes the workflow name.Are there changes in behavior for the user?
Nope.
Related issue number
N/A
Checklist