Skip to content

Issue 1195#1196

Merged
asvetlov merged 4 commits intoaio-libs:masterfrom
asvetlov:issue-1195
Jun 24, 2025
Merged

Issue 1195#1196
asvetlov merged 4 commits intoaio-libs:masterfrom
asvetlov:issue-1195

Conversation

@asvetlov
Copy link
Member

@asvetlov asvetlov commented Jun 24, 2025

Closes #1195

@asvetlov
Copy link
Member Author

The first commit has only a reproducer, not the fix itself.

I'm working on the latter.

@asvetlov asvetlov requested a review from webknjaz as a code owner June 24, 2025 18:16
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jun 24, 2025
@asvetlov
Copy link
Member Author

Long story short, when resizing multidicts, if an object has deleted items, it may drop live items instead of collecting the deleted slots.

The fix helps with this situation.

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 24, 2025

CodSpeed Performance Report

Merging #1196 will degrade performances by 22.27%

Comparing asvetlov:issue-1195 (261a785) with master (c90fade)

Summary

❌ 3 regressions
✅ 241 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_cimultidict_getall_istr_hit[py] 1.7 ms 2.1 ms -22.27%
test_multidict_getall_str_hit[ci-py] 1.7 ms 2.1 ms -22.14%
test_multidict_getall_str_hit[cs-py] 1.8 ms 2.3 ms -18.87%

@codecov
Copy link

codecov bot commented Jun 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.31%. Comparing base (c90fade) to head (261a785).
⚠️ Report is 40 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1196   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files          27       27           
  Lines        3856     3868   +12     
  Branches      704      704           
=======================================
+ Hits         3791     3803   +12     
  Misses         18       18           
  Partials       47       47           
Flag Coverage Δ
CI-GHA 98.31% <100.00%> (+<0.01%) ⬆️
MyPy 80.44% <100.00%> (+0.06%) ⬆️
pytest 99.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@asvetlov asvetlov merged commit 964d65f into aio-libs:master Jun 24, 2025
63 of 64 checks passed
@asvetlov asvetlov deleted the issue-1195 branch June 24, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

multidict 6.5.0 breaks httpie cli

1 participant