Skip to content

Setup pre-commit hook for auto-formating both Python and C code#1179

Merged
asvetlov merged 3 commits intomasterfrom
reformat
Jun 19, 2025
Merged

Setup pre-commit hook for auto-formating both Python and C code#1179
asvetlov merged 3 commits intomasterfrom
reformat

Conversation

@asvetlov
Copy link
Member

@asvetlov asvetlov commented Jun 19, 2025

Closes #1123

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jun 19, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Jun 19, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1179 will improve performances by 12.76%

Comparing reformat (f1697c5) with master (26987f9)

Summary

⚡ 2 improvements
✅ 242 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ test_cimultidict_getall_istr_miss[pure-python-module] 39.7 µs 35.2 µs +12.76%
⚡ test_multidict_getall_str_miss[case-insensitive-pure-python-module] 38.5 µs 34.2 µs +12.56%

@asvetlov
Copy link
Member Author

asvetlov commented Jun 19, 2025

Benchmarks for pure python tests are not stable after merging hashtable-based impl but this is another issue.

@asvetlov asvetlov enabled auto-merge (squash) June 19, 2025 12:01
@asvetlov asvetlov merged commit f428d50 into master Jun 19, 2025
63 checks passed
@asvetlov asvetlov deleted the reformat branch June 19, 2025 12:17
@codecov
Copy link

codecov bot commented Jun 19, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.31%. Comparing base (26987f9) to head (f1697c5).
⚠️ Report is 62 commits behind head on master.

Files with missing lines Patch % Lines
docs/conf.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1179   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files          27       27           
  Lines        3851     3852    +1     
  Branches      700      700           
=======================================
+ Hits         3786     3787    +1     
  Misses         18       18           
  Partials       47       47
Flag Coverage Δ
CI-GHA 98.31% <92.85%> (+<0.01%) ⬆️
MyPy 80.36% <92.85%> (+<0.01%) ⬆️
pytest 99.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@webknjaz
Copy link
Member

webknjaz commented Jun 19, 2025

Urgh.. Too bad that it's now not possible to put a commit into blame ignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdraco bdraco bdraco approved these changes

Assignees

No one assigned

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Setup pre-commit hook for auto-formating both Python and C parts

3 participants

@asvetlov @webknjaz @bdraco