Conversation
CodSpeed Performance ReportMerging #1167 will not alter performanceComparing Summary
|
|
The earliest python version that actions/setup-python supports for windows arm64 is 3.11 so I skipped the arm64 wheel tests for 3.9 & 3.10 but CIBuildWheel does build wheels for those versions and they pass the tests that it runs. Does that seem reasonable to skip those later tests in the workflow? |
asvetlov
left a comment
There was a problem hiding this comment.
@finnagin thanks for the PR!
How is ARM Windows different from x64?
From my understanding, API should be the same, at least for a subset af calls used by multidict.
Does it make sense to drop windows-11-arm from test job matrix but leave it in build-wheels job?
It doesn't waste additional CI time but provides the same level of test coverage since tests run as a part of the wheel building.
Sure! That makes sense to me. I can do that. |
|
Thanks! |
What do these changes do?
This would add builds for and run tests on arm64 windows wheels
Are there changes in behavior for the user?
No
Related issue number
Fixes #1166
Checklist