Skip to content

Fix segfault creating view objects#1163

Merged
bdraco merged 5 commits intomasterfrom
segfault_protected_view_objects
May 19, 2025
Merged

Fix segfault creating view objects#1163
bdraco merged 5 commits intomasterfrom
segfault_protected_view_objects

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented May 16, 2025

fixes #1161

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label May 16, 2025
@bdraco bdraco marked this pull request as ready for review May 16, 2025 20:11
@bdraco bdraco requested review from asvetlov and webknjaz as code owners May 16, 2025 20:11
@codspeed-hq
Copy link

codspeed-hq bot commented May 16, 2025

CodSpeed Performance Report

Merging #1163 will not alter performance

Comparing segfault_protected_view_objects (01ef6ab) with master (fea968f)

Summary

✅ 244 untouched benchmarks

@codecov
Copy link

codecov bot commented May 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.62%. Comparing base (fea968f) to head (01ef6ab).
⚠️ Report is 72 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1163   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          27       27           
  Lines        3558     3566    +8     
  Branches      561      561           
=======================================
+ Hits         3509     3517    +8     
  Misses         17       17           
  Partials       32       32           
Flag Coverage Δ
CI-GHA 98.62% <100.00%> (+<0.01%) ⬆️
MyPy 83.18% <62.50%> (-0.05%) ⬇️
pytest 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bdraco bdraco closed this May 18, 2025
@bdraco bdraco reopened this May 18, 2025
@bdraco bdraco merged commit b5a24b7 into master May 19, 2025
114 of 115 checks passed
@bdraco bdraco deleted the segfault_protected_view_objects branch May 19, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Segfault on repr of instances of _ItemsView, _KeysView or _ValuesView

1 participant