Skip to content

Tune multidict benchmark#1155

Merged
asvetlov merged 1 commit intomasterfrom
bench
Apr 27, 2025
Merged

Tune multidict benchmark#1155
asvetlov merged 1 commit intomasterfrom
bench

Conversation

@asvetlov
Copy link
Member

@asvetlov asvetlov commented Apr 27, 2025

Use arguments to get not the best but amortized (realistic) times.

@asvetlov asvetlov added the bot:chronographer:skip This PR does not need to include a change note label Apr 27, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 27, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1155 will degrade performances by 63.32%

Comparing bench (4f61a7b) with master (99e3f3b)

Summary

❌ 6 (👁 6) regressions
✅ 238 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
👁 test_cimultidict_pop_istr[c-extension-module] 84.3 µs 125.2 µs -32.67%
👁 test_cimultidict_pop_istr[pure-python-module] 889.8 µs 2,147.1 µs -58.56%
👁 test_multidict_pop_str[case-insensitive-c-extension-module] 106.3 µs 147.7 µs -28.04%
👁 test_multidict_pop_str[case-insensitive-pure-python-module] 859 µs 2,097.4 µs -59.04%
👁 test_multidict_pop_str[case-sensitive-c-extension-module] 70.1 µs 107.8 µs -34.95%
👁 test_multidict_pop_str[case-sensitive-pure-python-module] 589.4 µs 1,607.1 µs -63.32%

@codecov
Copy link

codecov bot commented Apr 27, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.62%. Comparing base (99e3f3b) to head (4f61a7b).
⚠️ Report is 75 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1155   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          27       27           
  Lines        3553     3553           
  Branches      561      561           
=======================================
  Hits         3504     3504           
  Misses         17       17           
  Partials       32       32
Flag Coverage Δ
CI-GHA 98.62% <100.00%> (ø)
MyPy 83.21% <100.00%> (ø)
pytest 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@asvetlov asvetlov enabled auto-merge (squash) April 27, 2025 07:30
@asvetlov asvetlov disabled auto-merge April 27, 2025 07:31
@asvetlov asvetlov enabled auto-merge (squash) April 27, 2025 07:32
@asvetlov asvetlov closed this Apr 27, 2025
auto-merge was automatically disabled April 27, 2025 07:45

Pull request was closed

@asvetlov asvetlov reopened this Apr 27, 2025
@asvetlov asvetlov merged commit 72f3fce into master Apr 27, 2025
115 checks passed
@asvetlov asvetlov deleted the bench branch April 27, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@asvetlov