Skip to content

Drop _Impl helper class, move all logic to MultiDict itself#1153

Merged
asvetlov merged 3 commits intomasterfrom
refactor-py
Apr 15, 2025
Merged

Drop _Impl helper class, move all logic to MultiDict itself#1153
asvetlov merged 3 commits intomasterfrom
refactor-py

Conversation

@asvetlov
Copy link
Member

The last part of #1149

@asvetlov asvetlov requested a review from webknjaz as a code owner April 14, 2025 19:10
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Apr 14, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 14, 2025

CodSpeed Performance Report

Merging #1153 will not alter performance

Comparing refactor-py (557eb58) with master (d476a03)

Summary

✅ 244 untouched benchmarks

@bdraco bdraco closed this Apr 14, 2025
@bdraco bdraco reopened this Apr 14, 2025
@bdraco
Copy link
Member

bdraco commented Apr 14, 2025

close reopen to restart CI

codecov should be fixed now per codecov/codecov-action#1811

@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.62%. Comparing base (d476a03) to head (557eb58).
Report is 76 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1153      +/-   ##
==========================================
- Coverage   98.62%   98.62%   -0.01%     
==========================================
  Files          27       27              
  Lines        3559     3553       -6     
  Branches      567      561       -6     
==========================================
- Hits         3510     3504       -6     
  Misses         17       17              
  Partials       32       32              
Flag Coverage Δ
CI-GHA 98.62% <100.00%> (-0.01%) ⬇️
MyPy 83.21% <8.33%> (+0.11%) ⬆️
pytest 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@asvetlov asvetlov merged commit 99e3f3b into master Apr 15, 2025
160 of 165 checks passed
@asvetlov asvetlov deleted the refactor-py branch April 15, 2025 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants