Skip to content

Views don't rely in _Impl anymore#1152

Merged
asvetlov merged 3 commits intomasterfrom
refactor-py
Apr 14, 2025
Merged

Views don't rely in _Impl anymore#1152
asvetlov merged 3 commits intomasterfrom
refactor-py

Conversation

@asvetlov
Copy link
Member

The second part of #1149

@asvetlov asvetlov requested a review from webknjaz as a code owner April 14, 2025 08:35
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Apr 14, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 14, 2025

CodSpeed Performance Report

Merging #1152 will not alter performance

Comparing refactor-py (4184079) with master (1d72435)

Summary

✅ 244 untouched benchmarks

@codecov
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.62%. Comparing base (1d72435) to head (4184079).
Report is 77 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1152      +/-   ##
==========================================
+ Coverage   98.56%   98.62%   +0.05%     
==========================================
  Files          27       27              
  Lines        3565     3559       -6     
  Branches      571      567       -4     
==========================================
- Hits         3514     3510       -4     
  Misses         17       17              
+ Partials       34       32       -2     
Flag Coverage Δ
CI-GHA 98.62% <100.00%> (+0.05%) ⬆️
MyPy 83.09% <11.42%> (+0.08%) ⬆️
pytest 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@asvetlov asvetlov requested a review from bdraco April 14, 2025 10:52
@asvetlov asvetlov merged commit d476a03 into master Apr 14, 2025
62 of 63 checks passed
@asvetlov asvetlov deleted the refactor-py branch April 14, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant