Skip to content

MultiDictProxy doesn't rely on '_impl' anymore#1150

Merged
asvetlov merged 5 commits intoaio-libs:masterfrom
asvetlov:refactor-py
Apr 13, 2025
Merged

MultiDictProxy doesn't rely on '_impl' anymore#1150
asvetlov merged 5 commits intoaio-libs:masterfrom
asvetlov:refactor-py

Conversation

@asvetlov
Copy link
Member

The first part of #1149

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Apr 11, 2025
@asvetlov asvetlov marked this pull request as ready for review April 11, 2025 07:00
@asvetlov asvetlov requested a review from webknjaz as a code owner April 11, 2025 07:00
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 11, 2025

CodSpeed Performance Report

Merging #1150 will not alter performance

Comparing asvetlov:refactor-py (3a6690e) with master (52f7411)

Summary

✅ 244 untouched benchmarks

@codecov
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

Attention: Patch coverage is 95.89041% with 6 lines in your changes missing coverage. Please review.

Project coverage is 98.56%. Comparing base (52f7411) to head (3a6690e).
Report is 78 commits behind head on master.

Files with missing lines Patch % Lines
multidict/_multidict_py.py 89.65% 0 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1150      +/-   ##
==========================================
- Coverage   98.69%   98.56%   -0.13%     
==========================================
  Files          27       27              
  Lines        3441     3565     +124     
  Branches      528      571      +43     
==========================================
+ Hits         3396     3514     +118     
  Misses         17       17              
- Partials       28       34       +6     
Flag Coverage Δ
CI-GHA 98.56% <95.89%> (-0.13%) ⬇️
MyPy 83.01% <69.86%> (-0.59%) ⬇️
pytest 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@asvetlov asvetlov merged commit 1d72435 into aio-libs:master Apr 13, 2025
62 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants