Skip to content

Fix custom PyType_GetModuleByDef when non-heap type object was passed#1147

Merged
bdraco merged 3 commits intomasterfrom
fix-assertion
Apr 10, 2025
Merged

Fix custom PyType_GetModuleByDef when non-heap type object was passed#1147
bdraco merged 3 commits intomasterfrom
fix-assertion

Conversation

@asvetlov
Copy link
Member

It affects the C Extension that was built in debug mode for Python<3.11

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Apr 10, 2025
@asvetlov asvetlov marked this pull request as ready for review April 10, 2025 11:05
@asvetlov asvetlov requested a review from webknjaz as a code owner April 10, 2025 11:05
@asvetlov asvetlov requested a review from bdraco April 10, 2025 11:05
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 10, 2025

CodSpeed Performance Report

Merging #1147 will not alter performance

Comparing fix-assertion (78d447f) with master (57c09c0)

Summary

✅ 244 untouched benchmarks

@asvetlov
Copy link
Member Author

My family and I are going on vacation.

I'll be only partially available until 21 of April.

@bdraco
Copy link
Member

bdraco commented Apr 10, 2025

Thanks @asvetlov

@bdraco bdraco merged commit cf690d5 into master Apr 10, 2025
47 checks passed
@bdraco bdraco deleted the fix-assertion branch April 10, 2025 19:44
@asvetlov
Copy link
Member Author

You are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided There is a change note present in this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants