Fix memory leak creating new istr objects#1133
Merged
Conversation
bdraco
commented
Apr 9, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1133 +/- ##
=======================================
Coverage 98.68% 98.68%
=======================================
Files 27 27
Lines 3432 3432
Branches 528 528
=======================================
Hits 3387 3387
Misses 17 17
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #1133 will improve performances by 42.32%Comparing Summary
Benchmarks breakdown
|
Member
Author
|
Thanks for the reviews. 0100 here so I'll get these merged and a release done tomorrow after some 💤 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes leak 1 from #1131 (comment) (
IStr_Newpath)see #1131 (comment) #1131 (comment) #1131 (comment)
This also seems to fix the perf regression in popitem from #1097 (comment)
https://codspeed.io/aio-libs/multidict/branches/istr-keys
introduced #1097
fixes #1131