Conversation
Note that the manylinux armv7l wheels might still not build and we will than have to add the exclude like we do for yarl since the previous manylinux image for armv7l did not have a working cffi package. In theory this has been fixed in https://github.com/pypa/cibuildwheel/releases/tag/v2.23.0
CodSpeed Performance ReportMerging #1127 will not alter performanceComparing Summary
|
webknjaz
reviewed
Apr 5, 2025
webknjaz
reviewed
Apr 5, 2025
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <webknjaz@redhat.com>
bdraco
added a commit
to aio-libs/frozenlist
that referenced
this pull request
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Copy the wheel build changes from
yarlto usearmv7lwhich also splits themanylinuxandmusllinuxjobs which means the release process will be a bit fasterNote that theyarl released fine with manylinux nowmanylinuxarmv7lwheels might still not build and we will than have to add the exclude like we do foryarlsince the previousmanylinuximage forarmv7ldid not have a workingcffipackage. In theory this has been fixed in https://github.com/pypa/cibuildwheel/releases/tag/v2.23.0Are there changes in behavior for the user?
armv7lwheels