CodSpeed Performance Report

Merging #1121 will not alter performance

_{Comparing fix_leak (9270505) with master (9a32040)}

Summary

✅ 244 untouched benchmarks

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 91.30%. Comparing base (9a32040) to head (9270505).
Report is 94 commits behind head on master.

@@            Coverage Diff             @@
##           master    #1121      +/-   ##
==========================================
- Coverage   91.36%   91.30%   -0.07%     
==========================================
  Files          52       52              
  Lines        6349     6391      +42     
  Branches      627      627              
==========================================
+ Hits         5801     5835      +34     
- Misses        113      121       +8     
  Partials      435      435              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Good finding.
Let's apply a little different fix.
_multidict_extend_parse_args() should incref all returned values; I suggest you don't change it.
But the caller should decref.
This is the standard practice in Python, let's keep it.

Please take a look at the current PR's state.
It fixes the bug but avoids reference stealing.
Borrowed references are dangerous, in CPython itself we are trying to get rid of them everywhere

Thanks! Thats much better and safer. 🚀

Will clean it up, add changelog, and get it shipped

If you get a chance, aio-libs/yarl#1456 could use a followup review.