Skip to content

Add leak tests for #1117#1120

Merged
bdraco merged 12 commits intomasterfrom
leak_tests
Apr 3, 2025
Merged

Add leak tests for #1117#1120
bdraco merged 12 commits intomasterfrom
leak_tests

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Apr 3, 2025 •
edited
Loading

Add xfail test coverage for leak reported in #1117

@bdraco bdraco added the bot:chronographer:skip This PR does not need to include a change note label Apr 3, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 3, 2025
View reviewed changes
bdraco and others added 5 commits April 2, 2025 14:57
@bdraco @github-advanced-security
Potential fix for code scanning alert no. 183: Redundant comparison
a2c643f 
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@bdraco
cleanup
1755181
@bdraco
cleanup
66557a2
@bdraco
avoid running leak tests during wheel builds
d053871
@bdraco
preen
4ae5b5e
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 3, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1120 will not alter performance

Comparing leak_tests (7755eb3) with master (e442d73)

Summary

✅ 244 untouched benchmarks

@codecov
Copy link

codecov bot commented Apr 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.30435% with 8 lines in your changes missing coverage. Please review.

Project coverage is 91.36%. Comparing base (e442d73) to head (7755eb3).
Report is 95 commits behind head on master.

Files with missing lines Patch % Lines
tests/isolated/multidict_extend_dict.py 88.23% 2 Missing ⚠️
tests/isolated/multidict_extend_multidict.py 86.66% 2 Missing ⚠️
tests/isolated/multidict_extend_tuple.py 88.23% 2 Missing ⚠️
tests/isolated/multidict_update_multidict.py 86.66% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1120      +/-   ##
==========================================
+ Coverage   91.27%   91.36%   +0.09%     
==========================================
  Files          42       52      +10     
  Lines        6176     6349     +173     
  Branches      618      627       +9     
==========================================
+ Hits         5637     5801     +164     
- Misses        105      113       +8     
- Partials      434      435       +1
Flag Coverage Δ
CI-GHA 91.36% <91.30%> (+0.09%) ⬆️
MyPy 83.79% <91.30%> (+0.21%) ⬆️
pytest 99.96% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bdraco bdraco marked this pull request as ready for review April 3, 2025 01:31
@bdraco bdraco requested a review from asvetlov as a code owner April 3, 2025 01:31
@bdraco bdraco merged commit 9a32040 into master Apr 3, 2025
46 of 47 checks passed
@bdraco bdraco deleted the leak_tests branch April 3, 2025 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees

No one assigned

Labels

bot:chronographer:skip This PR does not need to include a change note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bdraco