Skip to content

Implement .shutdown() for both sync and async APIs#720

Merged
asvetlov merged 13 commits intomasterfrom
shutdown
Dec 13, 2024
Merged

Implement .shutdown() for both sync and async APIs#720
asvetlov merged 13 commits intomasterfrom
shutdown

Conversation

@asvetlov
Copy link
Member

No description provided.

@asvetlov
Copy link
Member Author

The PR is slightly incompatible with the master; it raises SyncQueueShutdown/AsyncQueueShutdown instead of bare RunrimeError.

I would release janus 1.2.0 with the latest master first and later release 2.0.0 with this PR.

@asvetlov
Copy link
Member Author

GitHub cannot find any worker for CI run, maybe it will unfreeze itself tomorrow.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 12, 2024

CodSpeed Performance Report

Merging #720 will not alter performance

Comparing shutdown (044e491) with master (60f0bb3)

Summary

✅ 4 untouched benchmarks

@codecov
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 99.67846% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.40%. Comparing base (60f0bb3) to head (044e491).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
janus/__init__.py 98.43% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #720      +/-   ##
==========================================
+ Coverage   94.55%   95.40%   +0.85%     
==========================================
  Files           5        5              
  Lines        1470     1721     +251     
  Branches      129      154      +25     
==========================================
+ Hits         1390     1642     +252     
+ Misses         53       52       -1     
  Partials       27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asvetlov asvetlov merged commit a360601 into master Dec 13, 2024
@asvetlov asvetlov deleted the shutdown branch December 13, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant