Better organize lint and test dependencies#636
Conversation
- Rename ci deps to test deps to only install test deps in test CI job. - Move build, pre-commit, twine and types-setuptools to lint deps - Move tox to dev dep since it's never used in CI - Move cython into its own file so that it can be used as a constraint - Fix CI jobs and Makefile to use the appropriate requirement files
for more information, see https://pre-commit.ci
|
Approval needed for CI to run here. |
| env: | ||
| PIP_CONSTRAINT: requirements/ci.txt |
There was a problem hiding this comment.
Not sure if this removal is okay or not. Since it's a pure python build (thus not installing cython), I don't think this has any effect, but I may be mistaken.
There was a problem hiding this comment.
Ideally, it should start pinning setuptools too. I just didn't get to it.
webknjaz
left a comment
There was a problem hiding this comment.
I think this is mostly fine as long as CI and RTD don't crash. I'll probably watch to change things up at some point but that's no reason to block.
|
It seems that codecov has not come back with a status report, which blocks the auto-merge. Checking https://app.codecov.io/gh/aio-libs/frozenlist/pull/636 manually confirms that there's no coverage change. |
|
Oh, it looks like @Dreamsorcerer reduced the number of uploads in #620 for some reason and Codecov is now waiting for a few more, which aren't going to happen. We should recover the MyPy matrix, it seems. |
|
Can this PR be merged nevertheless? I can open a follow-up that recovers the mypy matrix if that helps. |
|
As mentioned in another thread, I think the mypy matrix will be unmaintainable, so probably better to just fix the number of expected uploads. |
|
This can probably be merged now. |
What do these changes do?
Are there changes in behavior for the user?
No.
Checklist
CHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.