Merged
Conversation
for more information, see https://pre-commit.ci
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
Dreamsorcerer
commented
Feb 13, 2025
Dreamsorcerer
commented
Feb 26, 2025
webknjaz
reviewed
Mar 13, 2025
| .tox/.tmp/.mypy/python-3.12/cobertura.xml, | ||
| .tox/.tmp/.mypy/python-3.10/cobertura.xml, | ||
| .tox/.tmp/.mypy/python-3.8/cobertura.xml | ||
| .tox/.tmp/.mypy/python-3.11/cobertura.xml |
Member
There was a problem hiding this comment.
We should be running against a matrix of Pythons..
Member
Author
There was a problem hiding this comment.
I've highlighted this every time someone tries to add a matrix for mypy. The extra Python versions never seem to catch any extra errors the user would encounter, but as we introduce more strict typing the internal errors in the codebase differ slightly, making it pretty much impossible to get mypy passing on all versions simultaneously.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update mypy config to the strict typing we use on other projects