Skip to content

🐛 Fix __class_getitem__ signature in classes#571

Merged
webknjaz merged 2 commits intoaio-libs:masterfrom
webknjaz:bugfixes/typing-__class_getitem__-signature
Dec 15, 2023
Merged

🐛 Fix __class_getitem__ signature in classes#571
webknjaz merged 2 commits intoaio-libs:masterfrom
webknjaz:bugfixes/typing-__class_getitem__-signature

Conversation

@webknjaz
Copy link
Copy Markdown
Member

This patch also increases the coverage level expectations in the Codecov config and adds a test that hits the line with the missing coverage.

Fixes #567

This patch also increases the coverage level expectations in the
Codecov config and adds a test that hits the line with the missing
coverage.

Fixes aio-libs#567
@webknjaz webknjaz added the bug Something isn't working label Dec 15, 2023
@webknjaz webknjaz self-assigned this Dec 15, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b5ffcd7) 85.02% compared to head (f27d9b9) 85.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
+ Coverage   85.02%   85.35%   +0.33%     
==========================================
  Files          11       11              
  Lines         681      683       +2     
  Branches       63       63              
==========================================
+ Hits          579      583       +4     
+ Misses         63       61       -2     
  Partials       39       39              
Flag Coverage Δ
CI-GHA 85.06% <100.00%> (+0.33%) ⬆️
MyPy 59.63% <100.00%> (+0.14%) ⬆️
OS-Linux 99.39% <100.00%> (+0.60%) ⬆️
OS-Windows 99.22% <100.00%> (+0.39%) ⬆️
OS-macOS 99.39% <100.00%> (+0.60%) ⬆️
Py-3.10.11 98.06% <75.00%> (+0.01%) ⬆️
Py-3.10.13 98.19% <75.00%> (+0.01%) ⬆️
Py-3.11.5 ?
Py-3.11.7 98.19% <75.00%> (+0.01%) ⬆️
Py-3.12.1 98.19% <75.00%> (+0.01%) ⬆️
Py-3.8.10 98.83% <100.00%> (+0.39%) ⬆️
Py-3.8.18 98.79% <100.00%> (+0.61%) ⬆️
Py-3.9.13 98.06% <75.00%> (+0.01%) ⬆️
Py-3.9.18 98.19% <75.00%> (+0.01%) ⬆️
Py-pypy7.3.11 97.67% <100.00%> (+0.40%) ⬆️
Py-pypy7.3.13 96.89% <75.00%> (+0.02%) ⬆️
VM-macos 99.39% <100.00%> (+0.60%) ⬆️
VM-ubuntu 99.39% <100.00%> (+0.60%) ⬆️
VM-windows 99.22% <100.00%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@webknjaz webknjaz merged commit 8348ed3 into aio-libs:master Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[code coverage confusion] __class_getitem__ in classes below 3.9 is not covered

1 participant