📦 Move packaging to PEP 517 in-tree backend#560
Merged
webknjaz merged 1 commit intoaio-libs:masterfrom Dec 9, 2023
Merged
Conversation
1aa27a9 to
d95289f
Compare
Comment on lines
+8
to
+13
| from ._backend import ( # type: ignore[assignment] # noqa: WPS436 | ||
| build_sdist, | ||
| build_wheel, | ||
| get_requires_for_build_wheel, | ||
| prepare_metadata_for_build_wheel, | ||
| ) |
Check notice
Code scanning / CodeQL
Unused import
Comment on lines
+17
to
+21
| from ._backend import ( # type: ignore[assignment] # noqa: WPS436 | ||
| build_editable, | ||
| get_requires_for_build_editable, | ||
| prepare_metadata_for_build_editable, | ||
| ) |
Check notice
Code scanning / CodeQL
Unused import
|
|
||
| # isort: split | ||
| from distutils.command.install import install as _distutils_install_cmd | ||
| from distutils.core import Distribution as _DistutilsDistribution |
Check warning
Code scanning / CodeQL
Importing value of mutable attribute
f41a2db to
d2c90c5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #560 +/- ##
===========================================
- Coverage 99.60% 75.98% -23.63%
===========================================
Files 2 2
Lines 254 254
Branches 23 23
===========================================
- Hits 253 193 -60
- Misses 1 61 +60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
00692b5 to
0afd279
Compare
0afd279 to
af6ac47
Compare
This essentially allows the cythonization opt-out be controlled by the `pure-python` PEP 517 config setting that can be passed to the corresponding build frontends via their respective CLIs.
664562a to
583a620
Compare
2 tasks
bdraco
added a commit
that referenced
this pull request
Oct 5, 2025
PR #560 added --config-settings=pure-python=false which makes dependabot fail to do dep updates. It looks like we did not notice for a long time since it was still doing actions updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This essentially allows the cythonization opt-out be controlled by the
pure-pythonPEP 517 config setting that can be passed to the corresponding build frontends via their respective CLIs.The users, and packagers are now supposed to explicitly pass the
pure-pythonconfig setting to their PEP 517 build frontends in use, when they need to make pure-python wheels.Additionally, Cython line tracing is exposed and helps measure code coverage in the PYX files.
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.