DNM: Experiment to speed up creating cookie morsels#9594
Closed
DNM: Experiment to speed up creating cookie morsels#9594
Conversation
This likely needs to be optimized upstream
CodSpeed Performance ReportMerging #9594 will improve performances by 12.91%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #9594 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 113 113
Lines 35284 35305 +21
Branches 4187 4189 +2
=======================================
+ Hits 34799 34820 +21
Misses 325 325
Partials 160 160
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Member
Author
|
It's a really simple optimization. The loop can be replaced with a dict update upstream. |
bdraco
commented
Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This likely needs to be optimized upstream but we can get an idea if its worth it here