Check address family to fill wsgi env properly#718
Merged
asvetlov merged 1 commit intoaio-libs:masterfrom Jan 5, 2016
Merged
Conversation
|
I must admit I don't have a good grasp of the underlying networking code. It seems to address the immediate issue with unpacking the sockname tuple. However in terms of equivalency to the old code.
|
131da95 to
6e48b17
Compare
Contributor
Author
|
@merrellb oh, I forgot it, thanks |
6e48b17 to
abe92fd
Compare
|
Cool. So we prefer to get SERVER_NAME and SERVER_PORT from the message rather than self.transport.get_extra_info('sockname')? |
Member
abe92fd to
61d8495
Compare
61d8495 to
2e5eb61
Compare
Contributor
Author
|
@asvetlov done. Also added skipTest if no AF_UNIX (appveyor) |
asvetlov
added a commit
that referenced
this pull request
Jan 5, 2016
Check address family to fill wsgi env properly
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.