Fix broken wsgi.py due to sockname info size#716
Fix broken wsgi.py due to sockname info size#716merrellb wants to merge 1 commit intoaio-libs:masterfrom
Conversation
Addresses issue introduced by cccb9cb
|
This failed immediately on any request when using aiobottle. Not sure how their codepath differs from existing wsgi tests. |
|
getsockname may return more then 2 values, e.g. in case of AF_INET6 (host, port, flowinfo, scopeid) Probably we should check the address family and call appropriate code to fill in variables. |
|
On my OSX box I do get back the four part tuple. I can't say I am familiar with flowinfo or scopeid so it isn't clear how helpful they would be to detect and add them to the 'environ' variable. Given the move to tuple unpacking in the earlier commit, this seemed like the quickest way to get wsgi working again :-) |
|
I'm with @redixin |
|
@asvetlov I've made a patch, but it adds one extra call |
|
|
|
Fixed by #718 |
Addresses issue introduced by cccb9cb