Skip to content

Fix issue #512: force sendfile fallback when using SSL.#513

Merged
asvetlov merged 2 commits intoaio-libs:masterfrom
jashandeep-sohi:sendfile-ssl
Sep 19, 2015
Merged

Fix issue #512: force sendfile fallback when using SSL.#513
asvetlov merged 2 commits intoaio-libs:masterfrom
jashandeep-sohi:sendfile-ssl

Conversation

@jashandeep-sohi
Copy link
Copy Markdown
Contributor

See issue #512.

@asvetlov
Copy link
Copy Markdown
Member

Please add a test to never forget about ssl again.

@jashandeep-sohi
Copy link
Copy Markdown
Contributor Author

I've just added a single test to StaticFileMixin which runs using a SSL server.
Or would it better to test everything with & without SSL?

@asvetlov
Copy link
Copy Markdown
Member

No, one test is enough. Thanks!

asvetlov added a commit that referenced this pull request Sep 19, 2015
Fix issue #512: force sendfile fallback when using SSL.
@asvetlov asvetlov merged commit 7c43151 into aio-libs:master Sep 19, 2015
@jashandeep-sohi jashandeep-sohi deleted the sendfile-ssl branch September 19, 2015 01:23
@lock
Copy link
Copy Markdown

lock bot commented Oct 30, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants