Skip to content

DNM: Refactor request header construction to reduce copying#10696

Closed
bdraco wants to merge 8 commits intomasterfrom
header_copying
Closed

DNM: Refactor request header construction to reduce copying#10696
bdraco wants to merge 8 commits intomasterfrom
header_copying

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Apr 4, 2025

No description provided.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 4, 2025

CodSpeed Performance Report

Merging #10696 will not alter performance

Comparing header_copying (69bf960) with master (db6faf7)

Summary

✅ 51 untouched benchmarks

@bdraco bdraco closed this Apr 4, 2025
@bdraco bdraco deleted the header_copying branch April 4, 2025 18:47
@codecov
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.70%. Comparing base (473746d) to head (69bf960).
Report is 455 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
aiohttp/client_reqrep.py 85.71% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10696      +/-   ##
==========================================
- Coverage   98.71%   98.70%   -0.01%     
==========================================
  Files         125      125              
  Lines       37445    37445              
  Branches     2075     2077       +2     
==========================================
- Hits        36963    36960       -3     
- Misses        335      337       +2     
- Partials      147      148       +1     
Flag Coverage Δ
CI-GHA 98.58% <85.71%> (-0.01%) ⬇️
OS-Linux 98.25% <85.71%> (-0.01%) ⬇️
OS-Windows 96.18% <85.71%> (-0.02%) ⬇️
OS-macOS 97.35% <85.71%> (-0.01%) ⬇️
Py-3.10.11 97.26% <85.71%> (-0.02%) ⬇️
Py-3.10.16 97.82% <85.71%> (ø)
Py-3.11.11 97.90% <85.71%> (-0.01%) ⬇️
Py-3.11.9 97.35% <85.71%> (-0.01%) ⬇️
Py-3.12.9 98.35% <85.71%> (-0.01%) ⬇️
Py-3.13.2 98.33% <85.71%> (-0.01%) ⬇️
Py-3.9.13 97.13% <85.71%> (-0.01%) ⬇️
Py-3.9.21 97.67% <85.71%> (ø)
Py-pypy7.3.16 81.79% <85.71%> (-5.17%) ⬇️
VM-macos 97.35% <85.71%> (-0.01%) ⬇️
VM-ubuntu 98.25% <85.71%> (-0.01%) ⬇️
VM-windows 96.18% <85.71%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco
Copy link
Member Author

bdraco commented Apr 10, 2025

recheck with latest multidict to see if this has changed

@bdraco bdraco closed this Apr 10, 2025
@bdraco bdraco reopened this Apr 10, 2025
@bdraco bdraco closed this Apr 10, 2025
@bdraco bdraco deleted the header_copying branch June 14, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant